feat: enum.merge_generic_tags #1083
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like I've fixed the compatibility with prefixing, though there should be tests added for it. When running it on my real codebase, I get a duplicate struct, a custom |
morrisonlevi
force-pushed
the
merge-generic-tags
branch
from
afcd632 to
f18826b
Compare
|
I've added tests, still having an issue with my real-world case and finding a sharable reproducer. Edit: the real-world issue was a mistake in that code after all! This is pretty much ready for review, once I squash commits. |
Merge generic enum tags Remove hidden state used to merge generic tags Remove "_Tag" suffix from external tag enum variants Factor out Dependencies::add_path Document merge_generic_tags
Squashed commit of the following: commit e4561c5 Author: Levi Morrison <[email protected]> Date: Wed Jun 18 12:04:16 2025 -0600 fix: cython commit f18826b Author: Levi Morrison <[email protected]> Date: Wed Jun 18 11:38:13 2025 -0600 test: enum.merge_generic_tags and export.prefix commit cb1f57a Author: Levi Morrison <[email protected]> Date: Tue Jun 17 15:14:37 2025 -0600 fix: whitespace commit 04764f9 Author: Levi Morrison <[email protected]> Date: Tue Jun 17 14:37:14 2025 -0600 remove unnecessary check commit bf7c2c9 Author: Levi Morrison <[email protected]> Date: Tue Jun 17 14:07:07 2025 -0600 fix: prefix with cursor commit f33f1f4 Merge: e8373f1 8021542 Author: Levi Morrison <[email protected]> Date: Tue Jun 10 16:26:16 2025 -0600 Merge branch 'master' into merge-generic-tags commit e8373f1 Author: Benjamin Davies <[email protected]> Date: Thu Jun 1 18:05:04 2023 +1200 Document merge_generic_tags commit 27c01a4 Author: Benjamin Davies <[email protected]> Date: Thu Jun 1 17:05:18 2023 +1200 Factor out Dependencies::add_path commit 9cd7c19 Author: Benjamin Davies <[email protected]> Date: Tue May 30 19:53:30 2023 +1200 Remove "_Tag" suffix from external tag enum variants commit bdf1c26 Author: Benjamin Davies <[email protected]> Date: Tue May 30 19:42:21 2023 +1200 Remove hidden state used to merge generic tags commit 57330a8 Author: Benjamin Davies <[email protected]> Date: Wed Sep 14 18:33:05 2022 +1200 Merge generic enum tags
morrisonlevi
force-pushed
the
merge-generic-tags
branch
from
e4561c5 to
210c6f0
Compare
|
I've squashed Ben's commits, and my own, so this can go cleanly into master once reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #785 that has merged in the latest master.
There appears to be an issue with combining this with
export.prefix: #785 (comment).