Ensure schema mismatch causes error and runs early #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstring to `ensure_table` states that if there is a schema mismatch an exception will be raised. This isn't actually true, I was under the impression that `create_table(..., exists_ok=True)` would raise if the schemas were different, but instead it proceeds without error.
By instantiating the BigQueryLoader in the on_processing_complete callback, we don't validate the tables until *after* we drain the pulse queue. This is bad because if there's an error (like a schema mismatch), we lose all those events forever. This way the pulse messages don't get consumed, so the data will still be there for consumption once the issue is fixed.
Member
Author
|
This PR adds some checks that would have prevented the regression I made to the ETL yesterday. |
bhearsum
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for reviewer:
referenced, the pull request should include the bug number in the title)
.circleci/config.yml) will cause environment variables (particularlycredentials) to be exposed in test logs
telemetry-airflow
responsibly.