Skip to content

if Prototype is loaded, remove its Array.toJSON #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edsu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

if Prototype is loaded, remove its Array.toJSON #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef3dc3d
if Prototype is loaded, remove its Array.toJSON which flattens arrays…
edsu Aug 22, 2013
e9caa88
temporarily remove Prototype's Array.toJSON to address @csillag's con…
edsu Aug 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/jschannel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,21 @@
if (!window.JSON || !window.JSON.stringify || ! window.JSON.parse) {
throw("jschannel cannot run this browser, no JSON parsing/serialization");
}
if (window.Prototype) {
// Some versions of Prototype ship with a broken Array.toJSON
// which flattens arrays into strings! Since we have a working
// JSON.stringify we can safely remove it.
// See: http://stackoverflow.com/questions/710586/json-stringify-bizarreness
console.log("patching Prototype's faulty Array.toJSON")
var stringify = window.JSON.stringify;
window.JSON.stringify = function(value) {
var _array_tojson = Array.prototype.toJSON;
delete Array.prototype.toJSON;
var r = stringify(value);
Array.prototype.toJSON = _array_tojson;
return r;
}
}

/* basic argument validation */
if (typeof cfg != 'object') throw("Channel build invoked without a proper object argument");
Expand Down