Skip to content

Conversation

maettuu
Copy link
Contributor

@maettuu maettuu commented Aug 6, 2025

This test was automatically generated and could serve as a regression test for PR #19184. The added test:

  • fails on the codebase prior to the PR
  • passes on the codebase after the PR
  • still passes against today’s pdf.js master branch

It verifies that ToUnicodeMap correctly maps Extension B characters (surrogate pairs) to their full Unicode code points using codePointAt.

This is part of our research at the ZEST group of University of Zurich in collaboration with Mozilla.
If you have any suggestions, questions, or simply want to learn more, feel free to contact us at [email protected] and [email protected].

Verifies that ToUnicodeMap correctly maps Extension B characters to their full Unicode code points using codePointAt

See PR mozilla#19184
@maettuu
Copy link
Contributor Author

maettuu commented Sep 4, 2025

Is the failing runUnitTestCli connected to my change? I could switch to the safer form String(0x20) instead of (0x20).toString() in case this is the culprit.

@timvandermeij
Copy link
Contributor

No, that seems to be an intermittent upstream issue in Node.js 24 and isn't related to your patch. I have retriggered that build and it's green now.

@maettuu
Copy link
Contributor Author

maettuu commented Sep 16, 2025

@calixteman Let me know if anything else is missing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants