feat: fix form calculation fields, related to #20214 #20223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
requested changes
Sep 1, 2025
src/core/annotation.js
Outdated
| decodedValue = decodedValue[0]; | ||
| } | ||
|
|
||
| class WidgetAnnotation extends Annotation { |
There was a problem hiding this comment.
Why is this class repeated inside the class with the exact same name and same of the exact same code? Does that actually work?
yarn.lock
Outdated
| @@ -0,0 +1,6507 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
This file needs to be removed; it's unrelated to the patch.
src/core/annotation.js
Outdated
| data.fieldValue = decodedValue; | ||
| } | ||
| /** | ||
| * Fix calculation values that show repeating patterns due to JavaScript execution errors |
There was a problem hiding this comment.
This feels a bit arbitrary to me. How do we know for sure that the repeated value wasn't intended by the user? Is there anything in the PDF specification that explains how to deal with this situation?
|
Please make sure the commits are squashed into one, and ensure that that commit has a good commit message that explains the issue and the approach for fixing it in a concise manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes :
This PR fixes issue #20214 where PDF form calculation fields display repeating digit patterns (e.g., "37037037" instead of "3" or "37.037.03" instead of "3") when calculated values are processed incorrectly by the PDF.js JavaScript engine.
Problem :
When users fill out PDF forms with calculated fields (like mean scores), the calculation results sometimes show malformed repeating patterns:
"37037037" instead of "37"
"37.037.03" instead of "3"
"333333" instead of "3"
This occurs when PDF calculation scripts run incorrectly in PDF.js JavaScript environment, causing string concatenation instead of proper numeric calculation.
Root Cause :
The issue stems from:
Solution :
Enhanced the WidgetAnnotation constructor's value processing logic
Added _fixRepeatingCalculationValue() method to detect and correct malformed calculation results
Implemented pattern detection for various types of calculation errors
Added comprehensive logging for debugging
Maintains full backward compatibility
Files Changed :