Skip to content

Add support for "SHA256CTR" filters #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 26, 2022
Merged

Add support for "SHA256CTR" filters #34

merged 8 commits into from
Apr 26, 2022

Conversation

jschanck
Copy link
Collaborator

Resolves #33

@jschanck jschanck requested a review from mozkeeler April 11, 2022 20:41
mozkeeler
mozkeeler reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general. I have a couple of questions/comments.

@jschanck jschanck mentioned this pull request Apr 12, 2022
Closed
mozkeeler
mozkeeler reviewed Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I have a few more comments. Also, just wanted to make sure you ran cargo fmt and cargo clippy?

mozkeeler
mozkeeler approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

mozkeeler
mozkeeler approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@mozkeeler
Copy link
Collaborator

Well, and actually, if you wanted to include tests for invalid layer numbers, that'd be great, but it's not actually important for security - more like a correctness thing, so...

@mozkeeler mozkeeler merged commit 412ba59 into mozilla:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozkeeler mozkeeler mozkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define a new and more performant type of SHA256-based filter
2 participants
@jschanck @mozkeeler