permit {.sref} links to individual paragraphs
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently an sref like `[exec.continues.on#5]{.sref}` correctly generates a link to p5 of `[exec.continues.on]`, but will generate a warning:
```
mpark/wg21: stable name exec.continues.on#5 not found
```
and then fail to include the subsection number. this PR fixes that.
mpark
reviewed
Jun 2, 2025
| @@ -365,7 +365,7 @@ def rm(): _diff('rmcolor', 'sout', 'del') | |||
|
|
|||
| if 'sref' in elem.classes and isinstance(elem, pf.Span): | |||
| target = pf.stringify(elem) | |||
| number = stable_names.get(target) | |||
| number = stable_names.get(target.split('#')[0]) | |||
There was a problem hiding this comment.
This looks great! Thanks for the fix. Can I suggest a minor change here where we do something like name = target.split('#')[0], then the debug message to print "stable name not found" rather than "stable name not found"?
|
Thanks for the fix @ericniebler! Do you mind also updating the doc and the test please? (Doc and Test) The test should be pretty easy to update and regenerate For the doc, if taking the screenshot is too much of a hassle, just leave it and I can do it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently an sref like
[exec.continues.on#5]{.sref}correctly generates a link to p5 of[exec.continues.on], but will generate a warning:and then fail to include the subsection number. this PR fixes that.