video/out/d3d11: add d3d11 composition mode support #16285
+73
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saltpi
changed the title
saltpi
changed the title
|
Download the artifacts for this pull request: Windows |
kasper93
reviewed
Apr 26, 2025
kasper93
reviewed
Apr 26, 2025
saltpi
force-pushed
the
master
branch
2 times, most recently
from
cf023de to
cad8ce3
Compare
|
Hello @kasper93 , all the issue mentioned has been resolved. It would be great if it could be reviewed and merged soon. Thanks! |
kasper93
reviewed
Jul 4, 2025
| @@ -31,6 +31,7 @@ Interface changes | |||
| :: | |||
|
|
|||
| --- mpv 0.41.0 --- | |||
| - add `--d3d11-output-mode` enable use specific output mode for creating the D3D11 swapchain. | |||
There was a problem hiding this comment.
Don't edit this file directly, add dedicated file in interface-changes directory.
| @@ -563,6 +577,9 @@ static bool d3d11_init(struct ra_ctx *ctx) | |||
| if (!mp_d3d11_create_swapchain(p->device, ctx->log, &scopts, &p->swapchain)) | |||
| goto error; | |||
|
|
|||
| if (ctx->opts.composition) { | |||
There was a problem hiding this comment.
nitpick, but please be consistent about brackets, we don't use them for single line statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to export d3d11 swapchain