Skip to content

Conversation

@LuciferVid
Copy link

@LuciferVid LuciferVid commented Nov 25, 2025

.

}

this.dispatchEvent( _moveEvent );
const gp = inputSource && inputSource.gamepad;

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'inputSource' always evaluates to true.
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 358.3
86.96
358.3
86.96
+0 B
+0 B
WebGPU 620.64
174.2
620.64
174.2
+0 B
+0 B
WebGPU Nodes 619.25
173.95
619.25
173.95
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.25
121.78
490.36
121.83
+109 B
+49 B
WebGPU 691.52
189.81
691.63
189.85
+109 B
+44 B
WebGPU Nodes 632.96
172.99
633.07
173.03
+109 B
+46 B

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 25, 2025

Please do not modify build files and package.json in a PR.

@danrossi
Copy link
Contributor

I just committed one PR to do this and this came in just after. It looks to be another vibe code spammer ? a tonne of recent fresh forks for random projects. What is going on.

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 27, 2025

It's indeed frustrating, see #32386 (comment).

Closing in favor of your PR, #32353.

@Mugen87 Mugen87 closed this Nov 27, 2025
@Mugen87 Mugen87 added this to the r182 milestone Nov 27, 2025
@danrossi
Copy link
Contributor

Someone else just piped up noticing the vibe code scams. Is it for clout, it's new and weird. Looks automated. I tried to report a previous account spamming here but github saw the PR/comment you closed so they didn't do anything. Will try again. This vibe coding mess is getting insane and wasting your time.

@danrossi
Copy link
Contributor

I love how proper chatgpt is though. I like the format of the title.

"feat(WebXRController):" Is this the expected format ? I will use this from now on.

@LuciferVid LuciferVid deleted the update-webxr-controller branch November 27, 2025 21:48
@danrossi
Copy link
Contributor

They removed the branch so not a bot. So weird. I've reported but not sure if they want to nip in the bud as it's getting worse.

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 28, 2025

feat(WebXRController):" Is this the expected format ? I will use this from now on.

No it isn't. Normally we use <ModuleName>: <Short Description>..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants