Skip to content

Code quality fix - Methods named "equals" should override Object.equals(Object) #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Code quality fix - Methods named "equals" should override Object.equals(Object) #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/corundumstudio/socketio/annotation/ScannerEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class ScannerEngine {
private Method findSimilarMethod(Class<?> objectClazz, Method method) {
Method[] methods = objectClazz.getDeclaredMethods();
for (Method m : methods) {
if (equals(m, method)) {
if (isEquals(m, method)) {
return m;
}
}
Expand Down Expand Up @@ -86,7 +86,7 @@ public void scan(Namespace namespace, Object object, Class<?> clazz)

}

private boolean equals(Method method1, Method method2) {
private boolean isEquals(Method method1, Method method2) {
if (!method1.getName().equals(method2.getName())
|| !method1.getReturnType().equals(method2.getReturnType())) {
return false;
Expand Down