Skip to content

Fix: support get activeElement in shadow DOM #46775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix: support get activeElement in shadow DOM #46775

wants to merge 6 commits into from

Conversation

trinhnguyen-vn
Copy link

@trinhnguyen-vn trinhnguyen-vn commented Aug 17, 2025 •
edited
Loading

Details

This pr is for fixing 2 problems

  1. Component using document.activeElement cannot detect focused elements inside shadow roots, this break keyborad navigation and focus management in web component using shadow DOM. Affected component: MenuLlist, FocusTrap,...

Solution: create new utility getActiveElement: traverse shadow DOM recursively to find active element

Related issues: #34061 , #44147

  1. SSR runtime errror: getScrollbarSize utility throws error in SSR environment where window and document are undefined.

Solution: add defensive check in getScrollbarSize to handle undefined document/window

Issue details:
image
image

@zannager zannager requested a review from DiegoAndai August 18, 2025 13:15
@zannager zannager added the type: bug It doesn't behave as expected. label Aug 18, 2025
@DiegoAndai DiegoAndai requested review from siriwatknp and removed request for DiegoAndai August 19, 2025 17:32
@oliviertassinari oliviertassinari added type: new feature Expand the scope of the product to solve a new problem. scope: all components Widespread work has an impact on almost all components. and removed type: bug It doesn't behave as expected. labels Aug 21, 2025
@mui-bot
Copy link

mui-bot commented Aug 21, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-46775--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 🔺+118B(+0.02%) 🔺+80B(+0.05%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 🔺+25B(+0.20%) 🔺+9B(+0.18%)

Details of bundle changes

Generated by 🚫 dangerJS against 04d8f17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

scope: all components Widespread work has an impact on almost all components. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trinhnguyen-vn @mui-bot @oliviertassinari @zannager @ZeeshanTamboli