[Autocomplete] Correct size passed to renderInput
#46986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangkhoa99
changed the title
Netlify deploy previewhttps://deploy-preview-46986--material-ui.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
@dangkhoa99 Before changing this we should find a reason as to why only small size is supported for TextField in the Autocomplete component. Perhaps we should git blame to find the reason behind this..
When I override default size Therefore, when I pass size prop as |
ZeeshanTamboli
added
the
scope: autocomplete
ZeeshanTamboli
changed the title
size passed to renderInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've chosen to forward the size prop directly from Autocomplete to its renderInput function. This addresses an issue where the TextField's default size setting (e.g., small) was being incorrectly inherited by renderInput. Direct prop passing guarantees that the intended Autocomplete size is correctly rendered, ensuring style consistency.