Skip to content

Conversation

sashni
Copy link
Contributor

@sashni sashni commented Aug 1, 2019

No description provided.

@KinanBab
Copy link
Member

KinanBab commented Aug 4, 2019

These are the comments from the code review session, I think you have already done a few of them, please check those that are done.

  • Override socket.on('share', callback) in extension to decrypt received shared in a loop, instead of doing that in base client.
  • Use 'arguments' in "many_secret_shares" function to pass any given arguments to secret share constructor
  • Create a clone secret share function inside secret_share objects in base, override it in extension to copy ratios.
  • Use clone in all primitives.
  • Make ratios an argument in jiff_server_generate_and_share function in the extension (similar to triplets)
  • Create 'are_shares_compatible' function in base, that checks if two shares are compatible to operate on together (have the same Zp, holders, etc), override it in extension to check ratios as well.
  • Use all the above to reduce the amount of duplicated code between base and extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants