flags: define "implicit" #329
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly to add a comment about that: it cannot be set from the userspace, so it should not be used in path-managers. Suggested-by: Saulius Krasuckas <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Pull Request Test Coverage Report for Build 19679730433Details
💛 - Coveralls |
sskras
reviewed
Nov 27, 2025
| * | ||
| * @note Do not set from the userspace to the kernelspace. | ||
| */ | ||
| #define MPTCPD_ADDR_FLAG_IMPLICIT (1U << 4) |
There was a problem hiding this comment.
Cool, thanks. Then I wonder whether it's possible to somehow protect this define against using it in the userspace... (except from moving it into the comment block, which would also prevent it from using in the kernelspace too).
Member
Author
There was a problem hiding this comment.
I don't think that's needed:
- if set, the kernel will reject it anyway. No need to prevent it from mptcpd I think if plugins devs cannot read the doc :)
- this
defineis only linked to the in-kernel PM, probably not so many plugins will look at controlling it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to add a comment about that: it cannot be set from the userspace, so it should not be used in path-managers.
Suggested-by: @sskras