plugin: expose subflow error to plugins #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error parameter to subflow_closed callback to allow plugins to identify the reason for subflow closure, such as network errors. The error value corresponds to the MPTCP_ATTR_ERROR attribute from the kernel, which equals sk_err from struct sock. If the error attribute is not present in the netlink message, it defaults to 0. Fixes multipath-tcp#330
Pull Request Test Coverage Report for Build 19768471729Details
💛 - Coveralls |
matttbe
requested changes
Nov 28, 2025
Member
matttbe
left a comment
matttbe
left a comment
There was a problem hiding this comment.
Thank you for having looked at that!
I just have two small suggestions if you don't mind.
| static bool const test_backup_4 = true; | ||
| static bool const test_server_side_4 = false; | ||
| static bool const test_deny_join_id0_4 = false; | ||
| static uint8_t const test_error_4 = 0; |
Member
There was a problem hiding this comment.
small detail: maybe good to put a non 0 value for one of them, just to check something different, no? That will not change much, but just by principle, just in case?
| * @param[in] laddr Local address information. | ||
| * @param[in] raddr Remote address information. | ||
| * @param[in] backup Backup priority flag. | ||
| * @param[in] error Subflow related event error. |
Member
There was a problem hiding this comment.
small detail, do you mind adding a bit more details, e.g. there might not be any error, it is an errno, and the value is a copy of sk_err.
Something like that?
Subflow closing error, if any. The 'errno'
set in 'sk_err', e.g. reset, timeout, etc.
Do you mind adding that (or something similar) in include/mptcpd/private/plugin.h as well please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error parameter to subflow_closed callback to allow plugins to identify the reason for subflow closure, such as network errors.
The error value corresponds to the
MPTCP_ATTR_ERRORattribute from the kernel, which equalssk_errfromstruct sock. If the error attribute is not present in the Netlink message, it defaults to 0.Fixes #330
Changes
mptcpd_plugin_ops.subflow_closedsignature to includeuint8_t errorparameter