Skip to content

Fix position desync with dead players (#928) #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix position desync with dead players (#928) #4453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94dfa5
Allow position updates for dead players
MohabCodeX Sep 11, 2025
d7f5a68
Merge branch 'master' into fix/position-desync-dead-players
Dutchman101 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Client/mods/deathmatch/logic/CNetAPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ void CNetAPI::DoPulse()

// Grab the local player
CClientPlayer* pPlayer = m_pPlayerManager->GetLocalPlayer();
if (pPlayer && !pPlayer->IsDeadOnNetwork())
if (pPlayer)
{
unsigned long ulCurrentTime = CClientTime::GetTime();

Expand Down
4 changes: 2 additions & 2 deletions Server/mods/deathmatch/logic/packets/CPlayerPuresyncPacket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ bool CPlayerPuresyncPacket::Read(NetBitStreamInterface& BitStream)
return false;

// Only read this packet if it matches the current time context that
// player is in.
if (!pSourcePlayer->CanUpdateSync(ucTimeContext))
// player is in. Allow position updates for dead players
if (!pSourcePlayer->CanUpdateSync(ucTimeContext) && !pSourcePlayer->IsDead())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think dead players can be synchronized if the time context doesn't match

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohabCodeX Please respond to the feedback

{
return false;
}
Expand Down