Skip to content

Fix instruction duration unit in estimated success probability calculation #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix instruction duration unit in estimated success probability calculation #445

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
129b60f
Update predictor(adding callbacks)
Mar 29, 2025
08889bd
Update
Apr 10, 2025
e2ff3fe
Restore helper.py and predictor.py to match upstream
Jul 29, 2025
1c32d15
Merge remote-tracking branch 'upstream/main'
Jul 29, 2025
28b5440
Retreat to original version
Aug 6, 2025
b51b7a6
Fix bug in native gate check by using basis_gates instead of Target
Aug 6, 2025
46100c7
Add test for ensuring compiled circuit has only native gates
Aug 7, 2025
6edc683
Add test for ensuring compiled circuit has only native gates
Shaobo-Zhou Aug 7, 2025
225c36d
Merge branch 'main' into test_PR
burgholzer Aug 7, 2025
35b2386
Fix instruction duration unit
Shaobo-Zhou Sep 5, 2025
771edd7
Merge branch 'test_PR' of https://github.com/Shaobo-Zhou/mqt-predicto…
Shaobo-Zhou Sep 5, 2025
65ed540
Merge branch 'main' into test_PR
flowerthrower Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mqt/predictor/reward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,10 @@ def estimated_success_probability(qc: QuantumCircuit, device: Target, precision:
if first_qubit_idx not in active_qubits:
continue

dt = device.dt # instruction durations are stored in unit dt
res *= np.exp(
-instruction.duration
* dt
/ min(device.qubit_properties[first_qubit_idx].t1, device.qubit_properties[first_qubit_idx].t2)
)
continue
Expand Down
Loading