Skip to content

Conversation

@todaywasawesome
Copy link

Just what the title says. The multi-stage part means we use separate containers for the build and the "runtime" so to speak. This way we can keep the image nice and small.

This also makes building the app very easy because you just need the Dockerfile, whereas before it relies on the user building the binary in the same directory as the binary.

You can see the image built here: https://hub.docker.com/r/todaywasawesome/kube-plex

Copy link
Owner

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and certainly makes builds easier 😄 could you remove the codefresh specific changes here for now? We don't currently have a CI system set up, but I think we're more likely to use something like GitHub actions as it saves having to configure additional external services 😄

@todaywasawesome
Copy link
Author

@munnerz PR updated to remove the files you didn't want. Should be good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants