Fix the create_message function for clients with no default service. #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the Client.create_message function expects a service parameter, this service was not passed on to the SOAP implementation. The SOAP binding would invariably use the default service in the client object, and raise an exception if it was not found. Fix this by adding an optional service parameter to the SoapBinding.create method as well. Fixes mvantellingen#833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the Client.create_message function expects a service parameter, this service was not passed on to the SOAP implementation. The SOAP binding would invariably use the default service in the client object, and raise an exception if it was not found.
Fix this by adding an optional service parameter to the SoapBinding.create method as well.
Fixes #833