refactor: simplify state of fs store entry #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will probably inline this once it is proven to work well
futures-buffered is reexported by n0-future, as I learned yesterday
...by reverting a change that I did because of some older version of clippy
it is present in global, so now we don't need to impl drop, we have it in on_shutdown
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/102/docs/iroh_blobs/ Last updated: 2025-08-05T10:55:20Z |
…ut a buggy system
We are just destructuring a Command::Spawn that we have created a few lines before.
rklaehn
commented
Aug 5, 2025
| mpsc::error::TrySendError::Full(cmd) => { | ||
| let entity_actor::Command::Spawn(spawn) = cmd else { | ||
| panic!() | ||
| unreachable!() |
There was a problem hiding this comment.
Forgot to do this in the last PR!
matheus23
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few things were stored twice, just to enable Drop. Now we don't need Drop anymore and can store them only once.
BaoFileHandle was a wrapper around a BaoFileHandleInner, which had the actual BaoFileStorage as well as the additional info needed to be able to implement Drop. Now we don't implement Drop anymore and can just pass in the required extra info in the persist call from on_shutdown!
In several other places we now have to give additional info when working with BaoFileHandle, but this is conveniently grouped in HashContext.
Breaking Changes
None
Notes & open questions
Change checklist