Skip to content

✨ NoBackups #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v2.0
Choose a base branch
from
Open

✨ NoBackups #196

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e90a2e
:sparkles: no backups
egorgasay Nov 10, 2023
5769ba4
:art: art fixes
egorgasay Nov 10, 2023
36e5c12
:art: art fixes
egorgasay Nov 10, 2023
2eea71a
:art: art fixes
egorgasay Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lumberjack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// Note that this is v2.0 of lumberjack, and should be imported using gopkg.in
// thusly:
//
// import "gopkg.in/natefinch/lumberjack.v2"
// import "gopkg.in/natefinch/lumberjack.v2"
//
// The package name remains simply lumberjack, and the code resides at
// https://github.com/natefinch/lumberjack under the v2.0 branch.
Expand Down Expand Up @@ -66,7 +66,7 @@ var _ io.WriteCloser = (*Logger)(nil)
// `/var/log/foo/server.log`, a backup created at 6:30pm on Nov 11 2016 would
// use the filename `/var/log/foo/server-2016-11-04T18-30-00.000.log`
//
// Cleaning Up Old Log Files
// # Cleaning Up Old Log Files
//
// Whenever a new logfile gets created, old log files may be deleted. The most
// recent files according to the encoded timestamp will be retained, up to a
Expand Down Expand Up @@ -98,6 +98,9 @@ type Logger struct {
// deleted.)
MaxBackups int `json:"maxbackups" yaml:"maxbackups"`

// NoBackups determines if new log files will be created if size limit is exceeded.
NoBackups bool `json:"nobackups" yaml:"nobackups"`

// LocalTime determines if the time used for formatting the timestamps in
// backup files is the computer's local time. The default is to use UTC
// time.
Expand Down Expand Up @@ -214,7 +217,7 @@ func (l *Logger) openNew() error {
name := l.filename()
mode := os.FileMode(0600)
info, err := osStat(name)
if err == nil {
if err == nil && !l.NoBackups {
// Copy the mode off the old logfile.
mode = info.Mode()
// move the existing file
Expand Down