Purge Deezloader comments and change Deezer error message (#432) #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owhyy
commented
Mar 9, 2024
Comment on lines
110
to
113
| try: | ||
| # Usually happens with deezloader downloads | ||
| raise NonStreamableError(f"{info['error']} - {info['message']}") | ||
| except KeyError: | ||
| raise NonStreamableError(info) |
There was a problem hiding this comment.
Also, is this error handling still necessary? If not, I can remove it as well and just raise NonStreamableError(info)
|
I was just about to do this myself lol why hasn't this been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first commit here so bear with me :)
This addresses #432 and removes everything related to deezloader from the config file (as I understand,
DeezloaderClientwas removed since https://dz.loaderapp.info/deezer is down, but the config wasn't updated).Let me know there's any more changes required