Limit the number of in-memory cached blocks per store #6898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/fscachelimit
branch
from
1a5914e to
cbc3355
Compare
|
Ran this through Gauge and it makes virtually no difference to the JetStream, KV, object store or filestore benchmarks. |
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/fscachelimit
branch
from
cbc3355 to
fbf720b
Compare
| @@ -313,6 +314,8 @@ const ( | |||
| maxBufReuse = 2 * 1024 * 1024 | |||
| // default cache buffer expiration | |||
| defaultCacheBufferExpiration = 10 * time.Second | |||
| // deault cache size before eviction | |||
|
|
||
| // If loading this block into the cache caused us to reach the eviction | ||
| // threshold for cached blocks, evict the oldest one. | ||
| if n, _ := mb.fs.evict.push(mb); n == defaultCacheEvictionThreshold { |
There was a problem hiding this comment.
How do we remove from evict on normal cache timeout? Don't see that code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache expiry timer may not be fast enough to expire blocks from the cache when a stream is under either heavy ingest or a high-speed readout, so try to cap the number of cached blocks to a set number. The
evictIPQ will start to pop entries for eviction once we reachdefaultCacheEvictionThreshold.Signed-off-by: Neil Twigg [email protected]