Not PR: architectural concept: compact JsonValue #1394
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an actual PR, because it breaks public JsonValue API π€·ββοΈ
The size of the current JsonValue (only object itself) is ~ 96 bytes.
The size of new JsonValue is ~ 24 bytes β 4 times smaller.
(see
io.nats.client.support.JsonParsingTests#usedMemory)The speed of working with the object does not seem to have changed (within the margin of error)
(see
io.nats.client.support.JsonParsingTests#testReadSpeed)If there can be significant amounts of objects in memory, then the difference will be noticeable.
E.g: for 50_000_000 objects
old 4.77 G
new 1.332 G
It passes the unit tests.
You might probably find this useful as a proof of concept or a source of inspiration π€