feat(js): add support for subject-based sequence constraints #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Jul 1, 2025
jetstream/tests/jetstream_test.ts
Outdated
| const js = jsm.jetstream(); | ||
|
|
||
| await Promise.all([ | ||
| js.publish("a.1.foo", "1:1"), // Last is 1 for aa.1.foo; 1 for a.1.*; |
jetstream/tests/jetstream_test.ts
Outdated
| await pc("a.1.bar", "a.1.*", 3, false); | ||
| await pc("a.1.bar", "a.1.*", 4, false); | ||
| await pc("a.1.bar", "a.1.*", 5, false); | ||
| await pc("a.1.bar", "a.1.*", 6, true); // Last is 8 for a.1.bar; 8 for a.1.*; |
There was a problem hiding this comment.
I understand that you copied the comment from the Go client, but I think it is wrong. Last is 6 for a.1.bar. However, inserting that new message will make a.1.bar sequence 8, since the original publishes ended at 7.
Maybe that's what the comment means, but if anything, the comment should explain why "6" is the proper sequence for this subject.
There was a problem hiding this comment.
yes I c/p the ns test... Let me print the sequences that it onboards and update the comment with that
There was a problem hiding this comment.
Fixed the comments/doc to be more useful
Introduced the `lastSubjectSequenceSubject` option to enable subject-specific sequence constraints when publishing messages. Updated relevant headers, types, and tests to support this feature. See nats-io/nats-server#5280 Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the
lastSubjectSequenceSubjectoption to enable subject-specific sequence constraints when publishing messages. Updated relevant headers, types, and tests to support this feature.See nats-io/nats-server#5280