INTERNAL: Remove duplicated pipe max item count vars. #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Jan 13, 2025
| } else { | ||
| PartitionedMap<Long, T> list = new PartitionedMap<>( | ||
| elements, CollectionPipedInsert.MAX_PIPED_ITEM_COUNT); | ||
| elements, MAX_PIPED_ITEM_COUNT); |
Collaborator
There was a problem hiding this comment.
여기도 다른 수정과 동일하게 1 line으로 하시죠.
| } else { | ||
| PartitionedList<Element<T>> list = new PartitionedList<>( | ||
| elements, CollectionPipedInsert.MAX_PIPED_ITEM_COUNT); | ||
| elements, MAX_PIPED_ITEM_COUNT); |
Collaborator
There was a problem hiding this comment.
여기도 다른 수정과 동일하게 1 line으로 하시죠.
| } else { | ||
| PartitionedList<Element<T>> list = new PartitionedList<>( | ||
| elements, CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT); | ||
| elements, MAX_PIPED_ITEM_COUNT); |
Collaborator
There was a problem hiding this comment.
여기도 다른 수정과 동일하게 1 line으로 하시죠.
| } else { | ||
| PartitionedMap<String, T> list = new PartitionedMap<>( | ||
| elements, CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT); | ||
| elements, MAX_PIPED_ITEM_COUNT); |
Collaborator
There was a problem hiding this comment.
여기도 다른 수정과 동일하게 1 line으로 하시죠.
brido4125
force-pushed
the
internal/pipeCount
branch
from
df76b0a to
60fcaee
Compare
jhpark816
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
https://github.com/jam2in/arcus-works/issues/654
⌨️ What I did
SetPipedExist,CollectionPipedUpdate,CollectionPipedInsert 에
존재하는 중복되는 pipeCount 변수 제거 후 이를 ArcusClient의 변수로 추가