CLEANUP: Remove deprecated method, asyncSetBulk() #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Oct 29, 2025
| if (!val.isSuccess()) { | ||
| rv.addFailedResult(key, new CollectionOperationStatus(false, String | ||
| .valueOf(val.isSuccess()), CollectionResponse.END)); | ||
| .valueOf(val.isSuccess()), CollectionResponse.FAILED_END)); |
Collaborator
There was a problem hiding this comment.
CollectionOperationStatus ์์ฑํ๋ ๊ธฐ์กด ์ฝ๋๊ฐ ๋ง์ด ์ด์ํ๋ค์.
- message๋ "true" or "false"๋ก ์ค์
- CollectionResponse.END๋ก ์ค์
์๋์ ๊ฐ์ด ์์ ํด์ผ ํ ๊ฒ ๊ฐ์ต๋๋ค. ๊ฒํ ๋ฐ๋๋๋ค.
if (!val.isSuccess()) {
rv.addFailedResult(key, toCollectionOperationStatus(val));
}
Collaborator
There was a problem hiding this comment.
๊ทผ๋ฐ ์ด ๋ฉ์๋ deprecated์ธ๋ฐ ์์ ํ ํ์๊ฐ ์๋์?
Collaborator
There was a problem hiding this comment.
@oliviarla
์ด ๋ฉ์๋๋ ์ธ์ ์ ๊ฑฐํ๋ฉด ๋ ๊น์?
Collaborator
There was a problem hiding this comment.
deprecate๋์ง 5๋ ์ด๋ ์ง๋ฌ๊ธฐ ๋๋ฌธ์ ์ด๋ฒ ๋ฆด๋ฆฌ์ฆ์์ ์ ๊ฑฐํด๋ ๋์ง ์๋ ์ถ์ต๋๋ค.
Collaborator
There was a problem hiding this comment.
@uhm0311
์ด๋ฒ์ asyncSetBulk ๋ฉ์๋๋ฅผ ์ ๊ฑฐํ์์ฃ .
Collaborator
Author
There was a problem hiding this comment.
๋ณ๊ฒฝํ์ต๋๋ค.
uhm0311
changed the title
jhpark816
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did
FAILED_END ์ํ๋ฅผ ๋ฐํํ๋๋ก ํฉ๋๋ค.