Skip to content

Conversation

Andy2003
Copy link
Collaborator

This PR adds all relevant integration tests, that exists in neo4j-graphql (js).

Following bugs where found and fixed:

  • handling paging correctly
  • handling duration and temporal scalars correctly
  • fixing union connection issues
  • using correct logical operator for SOME and SINGLE relation predicates

The test-framework is extended by the following features:

  • validating query results via JsonPath in asciidoc
  • testing custom resolvers via asciidoc
  • using neo4j-driver connection for integration tests

@Andy2003 Andy2003 added API-Alignment Align the API with the one defined by @neo4j/graphql fix Bugfix test Mraks PRs with adjusted test-cases labels Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Unit Test Results

       4 files         4 suites   1m 21s ⏱️
1 298 tests 1 283 ✔️ 15 💤 0
1 304 runs  1 289 ✔️ 15 💤 0

Results for commit 79c8c83.

♻️ This comment has been updated with latest results.

@Andy2003 Andy2003 self-assigned this Dec 12, 2024
@Andy2003 Andy2003 merged commit daf4b30 into master-v2 Dec 13, 2024
2 checks passed
@Andy2003 Andy2003 deleted the feature/v2-add-integartion-tests branch December 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-Alignment Align the API with the one defined by @neo4j/graphql fix Bugfix test Mraks PRs with adjusted test-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant