Skip to content
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
399a3a6
Images refresh batch 2
lidiazuin Aug 15, 2025
86a6ef6
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Aug 15, 2025
ed6b904
Add documentation for the alter database privileges on database level…
Hunterness Aug 19, 2025
fc82a2d
Update the description of the history option (#2543)
NataliaIvakina Aug 19, 2025
fe668fb
Add tabbed examples for multiple node IDs (#2512)
NataliaIvakina Aug 20, 2025
879932c
Images refresh batch 2
lidiazuin Aug 15, 2025
bfb7692
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Aug 21, 2025
3a9c6f0
reviewed images after feedback
lidiazuin Aug 28, 2025
ed698cb
review after feedback
lidiazuin Aug 29, 2025
41136da
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 1, 2025
50c621f
update of image
lidiazuin Sep 4, 2025
dbb011c
update image after review
lidiazuin Sep 5, 2025
c8dd59e
first updates after review (more to come)
lidiazuin Sep 10, 2025
f11978f
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 10, 2025
1da63da
Apply suggestions from code review
lidiazuin Sep 10, 2025
73f9704
updated images after review
lidiazuin Sep 11, 2025
f2e0f5c
updated images after review
lidiazuin Sep 15, 2025
afb9893
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 15, 2025
aa49d36
updated images after review
lidiazuin Sep 17, 2025
19bc44a
updated images after review
lidiazuin Sep 18, 2025
9b7b1a2
fixing centralization of text
lidiazuin Sep 18, 2025
ad5d925
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 18, 2025
d8afa0f
updated images after review
lidiazuin Sep 22, 2025
ee9bcc6
adding arrows to diagrams
lidiazuin Sep 24, 2025
463d1f5
updated images after review
lidiazuin Sep 24, 2025
59b368d
updated images after review
lidiazuin Sep 25, 2025
1071340
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 25, 2025
b5c58e5
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed modules/ROOT/images/backup-chain-aggregate.png
Binary file not shown.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small general nitpick I noticed as I compare with the old ones:
in the *|x[, ...] groups we previously only had the x part italic and not the * (or () or other such syntax characters).
Examples (both from this and other images):

  • (*|user[, ...])
  • *|name[, ...]
  • TO role[, ...]
  • {*|property[, ...]}

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 17 15

Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 19 37

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image I think some of your image comments doesn't load?

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
114 changes: 114 additions & 0 deletions modules/ROOT/images/privileges-grant-and-deny-syntax.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATABASE[S] should not be bold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not bold.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give you that when I zoom in, but in the full view it looks different than the others so something is different about it even if it isn't bold 🤔
image
image

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
90 changes: 90 additions & 0 deletions modules/ROOT/images/privileges-hierarchy-database.svg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alter database is missing
Screenshot 2025-09-08 at 13 04 42

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2541 (comment) I also noticed this :P

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
240 changes: 240 additions & 0 deletions modules/ROOT/images/privileges-hierarchy-dbms.svg
Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 31 37

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connections that you noted that don't derive from the same place are all coming from ALL DBMS PRIVILEGES, that's the style of the arrows used in the technical diagrams. I can try to change the style, but just letting you know that this is the default styling.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so, but they look misleading, so I decided to tell you if you can change them somehow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is better than the previous where the lines overlapped this kind of view still makes it hard to see that it's a hierarchy: the ALL [DBMS [PRIVILEGES]] are at the top of the hierarchy and contain everything under it, the USER MANAGEMENT is a sub-privilege to ALL [DBMS [PRIVILEGES]] and contain all of the other user privileges and so on.

Trying to look at this graph I could just as well think that SET USER PASSWORD[S] are the top privilege and that everything else falls under it :(

That is why the previous image was so wide - it needed to spread out downwards to help indicate the hierarchy (it also had arrows on the lines to follow from top privilege down to the 'leaf' privileges which also helped with this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I make it horizontal again, then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that I think yes, having the privileges in layers as we go deeper down the hierarchy 🤷

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
47 changes: 47 additions & 0 deletions modules/ROOT/images/privileges-hierarchy.svg
Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 54 58

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
160 changes: 160 additions & 0 deletions modules/ROOT/images/privileges-on-graph-syntax.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_grant_and_deny_syntax.svg

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

9 changes: 0 additions & 9 deletions modules/ROOT/images/privileges_hierarchy.svg

This file was deleted.

1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_hierarchy_dbms.svg

This file was deleted.

1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_on_graph_syntax.svg

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,7 @@ See link:{neo4j-docs-base-uri}/status-codes/{page-version}/notifications/all-not
The hierarchy between the different database privileges is shown in the image below.

// TODO: do we want two pictures, one for Cypher 5 and one for Cypher 25? I'd guess not but I'm not sure
image::privileges_hierarchy_database.svg[title="Database privileges hierarchy"]



image::privileges-hierarchy-database.svg[title="Database privileges hierarchy"]

.`GRANT ACCESS` privilege syntax
[cols="<15s,<85"]
Expand Down Expand Up @@ -529,8 +526,7 @@ GRANT [IMMUTABLE] TRANSACTION [MANAGEMENT] [( { * \| user[, ...] } )]
|===

// TODO: do we want two pictures, one for Cypher 5 and one for Cypher 25? I'd guess not but I'm not sure
image::privileges_grant_and_deny_syntax_database_privileges.svg[title="Syntax of `GRANT` and `DENY` database privileges"]

image::privileges-grant-and-deny-syntax-database-privileges.svg[width="800", title="Syntax of `GRANT` and `DENY` database privileges"]

[[access-control-database-administration-access]]
== The database `ACCESS` privilege
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ All DBMS privileges are relevant system-wide.
Like user management, they do not belong to one specific database or graph.
For more details on the differences between graphs, databases, and the DBMS, refer to link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-neo4j/[Cypher Manual -> Cypher and Neo4j].

image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of `GRANT` and `DENY` DBMS privileges"]

image::privileges_hierarchy_dbms.svg[width="800", title="DBMS privileges hierarchy"]
image::privileges-hierarchy-dbms.svg[width="800", title="DBMS privileges hierarchy", role=popup]

[NOTE]
====
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ All load privileges apply to the whole system.
Like DBMS privileges, they do not belong to one specific database or graph.
For more details on the differences between graphs, databases, and the DBMS, refer to link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-neo4j/[Cypher Manual -> Cypher and Neo4j].

image::privileges_grant_and_deny_syntax_load_privileges.svg[width="800", title="Syntax of GRANT and DENY load Privileges"]
image::privileges-grant-and-deny-syntax-load-privileges.svg[width="800", title="Syntax of `GRANT` and `DENY` load privileges", role=popup]

// TODO: add image later when there is more than one LOAD privilege
//image::privileges_hierarchy_load.svg[title="Load privileges hierarchy"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,15 @@ See link:{neo4j-docs-base-uri}/status-codes/{page-version}/notifications/all-not

The general `GRANT` and `DENY` syntaxes are illustrated in the following image:

image::privileges_grant_and_deny_syntax.svg[width="800", title="GRANT and DENY Syntax"]
image::privileges-grant-and-deny-syntax.svg[width="800", title="GRANT and DENY Syntax"]

A more detailed syntax illustration for graph privileges would be the following:

image::privileges_on_graph_syntax.svg[width="800", title="Syntax of GRANT and DENY Graph Privileges. The `{` and `}` are part of the syntax and not used for grouping."]
image::privileges-on-graph-syntax.svg[width="800", title="Syntax of GRANT and DENY Graph Privileges. The `{` and `}` are part of the syntax and not used for grouping."]

The following image shows the hierarchy between different graph privileges:

image::privileges_hierarchy.svg[title="Graph privileges hierarchy"]
image::privileges-hierarchy.svg[title="Graph privileges hierarchy", role=popup]



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,4 @@ Then, the Neo4j Helm chart creates Kubernetes entities needed for running and ac
The following diagram is a schematic representation of the Helm chart involved and the Kubernetes and Cloud resources it instantiates when installed:

.Neo4j standalone setup
image::standalone-on-k8s.svg[Example of Neo4j standalone setup in Kubernetes,width=700,role=popup]

image::standalone-on-k8s.svg[Example of Neo4j standalone setup in Kubernetes,width=700,role=popup]