-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
feat(fastify): add decorator for custom schema #14789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
piotrfrankowski
wants to merge
1
commit into
nestjs:master
Choose a base branch
from
piotrfrankowski:pf/feat/add-fastify-schema-decorators
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(fastify): add decorator for custom schema #14789
piotrfrankowski
wants to merge
1
commit into
nestjs:master
from
piotrfrankowski:pf/feat/add-fastify-schema-decorators
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4564b87f-2f8f-4f0f-8778-fcf6b60673ffDetails
💛 - Coveralls |
1ea8967
to
e764223
Compare
1 task
e764223
to
846d35a
Compare
Hardanish-Singh
approved these changes
Apr 14, 2025
7 tasks
Add an ability to attach json schema to request with a RequestSchema decorator
846d35a
to
a5dab19
Compare
cyber-hari
approved these changes
Jun 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @piotrfrankowski
Tony133
approved these changes
Jun 22, 2025
This should include some documentation on how to use it. |
Oh, and it should have example usage in the fastify example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ability to attach json schema to request with a RequestSchema decorator
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there is no easy way of using fastify's schema property and adding a response schema can have positive impact on performance source
Issue Number: N/A
What is the new behavior?
This PR adds a new decorator
RequestSchema
that takes a schema object and sets it asschema
property on fastify route docDoes this PR introduce a breaking change?