Fix/file type peer dependency #15364
Open
+8,252
−12,077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 05c47aac-d54b-49df-839c-d5f1aa8a4d4eDetails
💛 - Coveralls |
|
All tests and lint checks are now passing ✅. However, the benchmark check is currently failing due to an external issue: The Codechecks.io service used for benchmarking appears to be offline for maintenance, returning a 503 Service Unavailable response This error is unrelated to the changes in this PR and seems to stem from the benchmarking service itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The FileTypeValidator dynamically imports the file-type package using loadEsm. This approach can lead to loading the wrong version of file-type if another package (like jimp) installs a different version that gets hoisted, resulting in inconsistent or incorrect file validation results.
This was reported in #15270, where developers were encountering issues like:
Validation failed (current file type is application/octet-stream, expected type is ...)
Issue Number: 15270
What is the new behavior?
Replaced dynamic import using loadEsm with a direct static import:
import { fileTypeFromBuffer } from 'file-type';
Does this PR introduce a breaking change?
Other information
This fix ensures more predictable and stable validation behavior in file uploads by removing reliance on hoisted or mismatched file-type versions. It improves compatibility and aligns the package with modern best practices for peer dependency handling.