Skip to content

Conversation

@tafaust
Copy link

@tafaust tafaust commented Oct 29, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

As of now, the swagger-ui has no checksums on style or script.

Issue Number: #2667

What is the new behavior?

Checksums for custom js or css can be set via module options.

Does this PR introduce a breaking change?

  • Yes
  • No

The SwaggerCustomOptions changed. In particular the customJs, customJsStr, customCssUrl.

Other information

Tests and conventional commit conformance will be aligned with contribution guidelines upon non-draft status.

@tafaust
Copy link
Author

tafaust commented Nov 1, 2023

In case the oauth2-redirect.html from the dependency dist is used, please see swagger-api/swagger-ui#7540 (comment) where I hope SRI is included in the near future.

@tafaust
Copy link
Author

tafaust commented Nov 19, 2023

May I receive some feedback on my question here #2667 (comment)?

@tafaust tafaust marked this pull request as ready for review May 5, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant