fix(plugin): correct enum+nullable handling for Enum | null (and ar…
#3544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rays); avoid lazy
typefor enum unionsContext:
When a DTO property used a union like
Enum | null(orEnum[] | null) the plugin sometimes:type: () => FooEnum(unnecessary for enums; can cause circular refs), orenum: FooEnumentirely for optional+nullable cases (e.g.?: Status | null).Root cause:
createTypePropertyAssignmentsdidn’t special-case enum unions, so it fell back to a lazytype.createEnumPropertyAssignmentcould return early when the checker reported a union containing null/undefined or when array unwrapping wasn’t detected up front, dropping theenum.What changed:
Handle enum unions in
createTypePropertyAssignments:type. * Only addnullable: truewhennullis part of the union.createEnumPropertyAssignment.Rewrite
createEnumPropertyAssignmentto be union- and optional-safe:null/`undefined` from unions before enum detection.isArrayafter resolving enum-like types.FooEnum.ONE) which aren’t referenceable as enum types.Results:
Enum | null→{ enum: FooEnum, nullable: true }Enum[] | null→{ enum: FooEnum, isArray: true, nullable: true }?: Enum | null→{ required: false, enum: FooEnum, nullable: true }string | null) still emittype+nullable(as before).undefinedcontinues to affectrequired(based on?), notnullable— unchanged.Tests:
test/plugin/fixtures/nullable.dto.tsasserts correct transpiled metadata.Affects:
Fixes: #3519
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information