Expand Global iBGP Fabric Params #574
Conversation
roles/dtc/common/templates/ndfc_fabric/dc_vxlan_fabric/advanced/dc_vxlan_fabric_advanced.j2
Outdated
Show resolved
Hide resolved
roles/dtc/common/templates/ndfc_fabric/dc_vxlan_fabric/resources/dc_vxlan_fabric_resources.j2
Outdated
Show resolved
Hide resolved
Get Features list with status for additional parameters in fabric
add Performance monitoring only if feature enable. Feature is checked in connectivity_check as ndfc_version
|
@mikewiebe please take a look at this PR |
roles/dtc/common/templates/ndfc_fabric/dc_vxlan_fabric/resources/dc_vxlan_fabric_resources.j2
Outdated
Show resolved
Hide resolved
| STP_BRIDGE_PRIORITY: {{ vxlan.global.ibgp.spanning_tree.bridge_priority | default(defaults.vxlan.global.ibgp.spanning_tree.bridge_priority) }} | ||
| {% endif %} | ||
| {% endif %} | ||
| POWER_REDUNDANCY_MODE: {{ vxlan.global.ibgp.power_redundancy | default(defaults.vxlan.global.ibgp.power_redundancy) }} |
There was a problem hiding this comment.
Do these also need to be considered for other fabric types?
There was a problem hiding this comment.
Power could be also in External, ISN or eBGP, but currently only updated for VxLAN_EVPN
There was a problem hiding this comment.
Let's enable this in the other fabric types where applicable
| {% set l3_vlan_range = defaults.vxlan.global.ibgp.layer3_vlan_range.from ~ '-' ~ defaults.vxlan.global.ibgp.layer3_vlan_range.to %} | ||
| {% endif %} | ||
| VRF_VLAN_RANGE: {{ l3_vlan_range }} | ||
| SUBINTERFACE_RANGE: {{ vxlan.global.ibgp.sub_int_range | default(defaults.vxlan.global.ibgp.sub_int_range) }} |
There was a problem hiding this comment.
Same question here about other fabric types
There was a problem hiding this comment.
also available on external and ISN, with eBGP I think it's also present in General instead of resources
There was a problem hiding this comment.
Let's enable this in the other fabric types where applicable
| RR_COUNT: {{ vxlan.global.ibgp.route_reflectors | default(defaults.vxlan.global.ibgp.route_reflectors) }} | ||
| ANYCAST_GW_MAC: {{ vxlan.global.ibgp.anycast_gateway_mac | default(defaults.vxlan.global.ibgp.anycast_gateway_mac) }} | ||
| {% if (ndfc_features | selectattr('name', 'equalto', 'Performance Monitoring') | selectattr('admin_state', 'equalto', 'enabled') | list | length > 0) %} | ||
| PM_ENABLE: {{ vxlan.global.ibgp.performance_monitoring | default(defaults.vxlan.global.ibgp.performance_monitoring) | ansible.builtin.bool }} |
There was a problem hiding this comment.
If we enable this, are there other aspects of programmable reports we need to consider here? What exactly is the use case here for enabling this?
There was a problem hiding this comment.
The goal is only to enable the option based on feature status at ND level. The next part report, etc will be manual.
| - name: Get Cisco Nexus Dashboard Fabric Controller Features | ||
| cisco.dcnm.dcnm_rest: | ||
| method: GET | ||
| path: /appcenter/cisco/ndfc/api/v1/fm/features |
There was a problem hiding this comment.
I think we need to move this into an action plugin because we very likely need to handle multiple versions of ND. Not sure if this will work in it's current for for ND4.1 but we need to very that.
|
@ccoueffe given the additional options and refactoring we need to do here to handle the other fabric types (with testing) and moving the fabric feature logic into an action plugin and determining if we can support ND3.1, ND3.2 and ND4.1 I don't think we can include this in the 0.5.1 release |
4 participants
Related Issue(s)
Related Collection Role
Related Data Model Element
Proposed Changes
Add new parameter for ibgp vxlan evpn
Test Notes
Cisco NDFC Version
Checklist