Fixes for #4352 #4353
Open
Fixes for #4352 #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(client): Pass setup key to service run command The `netbird service run` command did not correctly handle the `--setup-key` or `--setup-key-file` flags. This was because the setup key was not being passed to the service when it was started. This commit fixes the issue by: - Passing the setup key from the `service run` command to the server instance. - Ensuring the `getSetupKey` function is called to read the key from a file if provided. - Passing the setup key through the connection client to the login function. - Updating all calls to `NewConnectClient` to include the setup key. With this change, the `netbird service run` command now correctly uses the setup key to register the peer.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(client): Pass setup key to service run command
No idea if this correctly solves or addresses #4352 but it did work when I tested it.
The
netbird service runcommand did not correctly handle the--setup-keyor--setup-key-fileflags. This was because the setup key was not being passed to the servicewhen it was started.
This commit fixes the issue by:
service runcommand to the server instance.getSetupKeyfunction is called to read the key from a file if provided.NewConnectClientto include the setup key.With this change, the
netbird service runcommand now correctly uses the setup key to registerthe peer.
Checklist
Documentation
Select exactly one:
Fixes expected behavior