-
-
Notifications
You must be signed in to change notification settings - Fork 906
[client,management,signal] Handle grpc from ws proxy internally instead of via tcp #4593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the WebSocket proxy implementation to handle gRPC connections internally through HTTP/2 instead of proxying to external TCP endpoints. This eliminates the need for TLS, TCP connections, and server name mismatches by using in-memory pipes and direct gRPC handler integration.
- Replaced TCP connection handling with in-memory pipe connections
- Updated the proxy to accept gRPC handlers directly instead of TCP addresses
- Simplified connection management and error handling logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
util/wsproxy/server/proxy.go | Core refactor replacing TCP-based proxying with direct gRPC handler integration via HTTP/2 |
signal/cmd/run.go | Updated to pass gRPC server instance instead of TCP address to websocket proxy |
management/internals/server/server.go | Updated to pass gRPC handler instead of TCP address to websocket proxy |
client/grpc/dialer.go | Simplified TLS handling for JavaScript runtime by removing InsecureSkipVerify option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Describe your changes
This eliminates TLS, TCP and any server name mismatches
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__