Fix contact groups #1481
Draft
Fix contact groups #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several places in `netbox_utils.py` that referred to `contact_groups` for no apparent reason, and some that referred to `contact_group` despite the feature being buggy (see netbox-community#1182). As a contact can belong to multiple groups, I think `contact_groups` makes more sense, and fixes the bugggy behavior.
Contributor
Author
|
I just discovered that https://github.com/netbox-community/netbox/releases/tag/v4.3.0 changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1182
New Behavior
netbox_contactmodule, renamecontact_grouptocontact_groups.Contrast to Current Behavior
Currently you can only specify a single group per contact, and you must use an integer ID which is difficult to do in ansible (see #1182).
After this change you can specify a list of groups by name or slug, which is more useful and more ergonomic.
Discussion: Benefits and Drawbacks
This is a breaking change, as anyone who has succeeded in using the old broken
contact_groupfield despite the bugginess will need to update.The new API is much nicer IMHO.
I suspect
contact_groupswas the original intention that simply wasn't finished correctly, as there were several references to it innetbox_utils.pyalready. I only had to add threess tonetbox_utils.pyto get it working nicely.Changes to the Documentation
No changes besides the updated auto module docs.
Proposed Release Note Entry
Change
netbox_contacts.contact_grouptocontact_groups(see #1182)Double Check
develbranch.