-
Notifications
You must be signed in to change notification settings - Fork 12
fix: restore missing Netlify global type in @netlify/functions
#434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhalp
merged 12 commits into
main
from
copilot/fix-4af91537-29e3-46a8-afa1-d052146c6d7b
Aug 28, 2025
+38
−3
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1fe6b21
Initial plan
Copilot 2b32dcb
Add TypeScript global augmentation for Netlify global variable
Copilot e8bd38b
Remove irrelevant var comment and change var to const in global decla…
Copilot 2e972b7
Add TypeScript regression test for Netlify global declaration
Copilot daded77
Add vitest type checking test for Netlify global declaration regression
Copilot 7724041
fix: configure ESLint for vitest type testing and update test name
Copilot 923385e
feat: configure vitest typecheck to enable proper type validation in …
Copilot 8100742
Merge branch 'main' into copilot/fix-4af91537-29e3-46a8-afa1-d052146c…
serhalp d6e828f
test: actually enable vitest type tests
serhalp 6ce5bce
chore: fix existing vitest type tests
serhalp 33b8ec5
build: add missing `skipLibCheck`
serhalp 4f30a4d
Merge branch 'main' into copilot/fix-4af91537-29e3-46a8-afa1-d052146c…
serhalp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { describe, test, expectTypeOf } from 'vitest' | ||
| import type { NetlifyGlobal } from '@netlify/types' | ||
|
|
||
| // Import the main module to ensure global augmentation is loaded | ||
| import './main.js' | ||
|
|
||
| describe('Netlify global type declaration regression test', () => { | ||
| test('should augment global scope with `Netlify` global', () => { | ||
| expectTypeOf<typeof Netlify>().toEqualTypeOf<NetlifyGlobal>() | ||
serhalp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expectTypeOf<typeof Netlify>().toHaveProperty('env') | ||
| expectTypeOf<typeof Netlify>().toHaveProperty('context') | ||
serhalp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.