feat: Add pcap receiver #421
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey~
This PR (not ready for prod yet, I'd like to discuss some implementation details) adds support for PCAP receiver. I.e, reading a pcap file to replay it through goflow. (Issue #415 )
I have a few questions :
I've implemented a "stub" receiver that returns an error by default (with a build tag to build the pcap version). Wdyt ?
If you agree with that approach, I can add documentation and build within the CI ~
There are currently two adjacent things :
But currently there's only the listener argument which conflates the two in one.
Do you have an idea / recommendation into which way you'd prefer me to implement ?
Thanks by advance,