Skip to content

Only build openssl-classes and boringssl-static on windows #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only build openssl-classes and boringssl-static on windows #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a5865
Only build openssl-classes and boringssl-static on windows
normanmaurer Jun 20, 2023
4400648
Rework profiles
normanmaurer Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
build-windows-m2-repository-cache-

- name: Build netty-tcnative-boringssl-static
run: ./mvnw.cmd --file pom.xml -am -pl boringssl-static clean package
run: ./mvnw.cmd --file pom.xml clean package

- uses: actions/upload-artifact@v3
if: ${{ failure() }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
stage-snapshot-windows-m2-repository-cache-

- name: Build netty-tcnative-boringssl-static
run: ./mvnw.cmd --file pom.xml -am -pl boringssl-static clean package org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DaltStagingDirectory=local-staging -DskipRemoteStaging=true -DskipTests=true
run: ./mvnw.cmd --file pom.xml clean package org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DaltStagingDirectory=local-staging -DskipRemoteStaging=true -DskipTests=true

- name: Upload local staging directory
uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
build-pr-windows-m2-repository-cache-

- name: Build netty-tcnative-boringssl-static
run: ./mvnw.cmd --file pom.xml -am -pl boringssl-static clean package
run: ./mvnw.cmd --file pom.xml clean package

- uses: actions/upload-artifact@v3
if: ${{ failure() }}
Expand Down
46 changes: 36 additions & 10 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,7 @@
<plugin>
<artifactId>maven-release-plugin</artifactId>
<configuration>
<!-- Specifying a profile here will disable the all profile, since it's activeByDefault -->
<arguments>-Prestricted-release,sonatype-oss-release -DmoduleSelector=none</arguments>
<arguments>-Prestricted-release,sonatype-oss-release</arguments>
<tagNameFormat>@{project.artifactId}-@{project.version}</tagNameFormat>
<autoVersionSubmodules>true</autoVersionSubmodules>
</configuration>
Expand Down Expand Up @@ -788,16 +787,43 @@
</modules>
</profile>

<!--
Profile for building all modules. This is enabled by default so if any profile is manually specified,
this will be disabled automatically.
-->

<profile>
<id>windows-compile-static-only</id>
<activation>
<os>
<family>windows</family>
</os>
</activation>
<modules>
<!-- Ony Windows we only support boringssl-static -->
<module>openssl-classes</module>
<module>boringssl-static</module>
</modules>
</profile>

<profile>
<id>all</id>
<id>linux-compile-all</id>
<activation>
<property>
<name>!moduleSelector</name>
</property>
<os>
<family>linux</family>
</os>
</activation>
<modules>
<module>openssl-classes</module>
<module>openssl-dynamic</module>
<module>openssl-static</module>
<module>boringssl-static</module>
<module>libressl-static</module>
</modules>
</profile>

<profile>
<id>osx-compile-all</id>
<activation>
<os>
<family>osx</family>
</os>
</activation>
<modules>
<module>openssl-classes</module>
Expand Down