Introduce powercom_sdcmd_discrete_delay flag for Powercom Raptor and Smart KING Pro series
#3009
Conversation
…RAPTOR RPT-1500AP LCD practice) [networkupstools#3000] Authored-by: https://github.com/aleka204 Signed-off-by: Jim Klimov <[email protected]>
…ID [networkupstools#3000] Signed-off-by: Jim Klimov <[email protected]>
…RAPTOR RPT-1500AP LCD practice) - fix messages [networkupstools#3000] Signed-off-by: Jim Klimov <[email protected]>
…, NEWS.adoc: introduce powercom_sdcmd_discrete_delay flag for Powercom Raptor and Smart KING Pro series [networkupstools#3000] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
USB
Powercom
Incorrect or missing readings
|
✅ Build nut 2.8.3.3335-master completed (commit 301110cee6 by @jimklimov) |
|
✅ Build nut 2.8.3.3338-master completed (commit db53ed6fde by @jimklimov) |
jimklimov
added
the
need testing
|
@aleka204 : can you please check if a custom NUT build from this branch works for your devices (with probably confusing behaviors, as per spec they seem to conflate delays before power-off and start-up) and does solve your issue #3000? See e.g. https://github.com/networkupstools/nut/wiki/Building-NUT-for-in%E2%80%90place-upgrades-or-non%E2%80%90disruptive-tests about getting prerequisites, building NUT, and testing a driver from the build workspace. |
|
Parking the PR as "draft" for now, until it is tested that there's some practical value to it, or more work needs to be done :) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* For powercom_sdcmd_discrete_delay we also read minutes | ||
| * from DelayBeforeStartup (same as for older dialects). | ||
| * FIXME: ...but theoretically they can be 32-bit (1..99999) | ||
| */ |
Check notice
Code scanning / CodeQL
FIXME comment Note
| #ifdef HAVE_PRAGMA_GCC_DIAGNOSTIC_IGNORED_TAUTOLOGICAL_CONSTANT_OUT_OF_RANGE_COMPARE | ||
| # pragma GCC diagnostic ignored "-Wtautological-constant-out-of-range-compare" | ||
| #endif | ||
| if (iv < 0 || (intmax_t)iv > (intmax_t)UINT32_MAX) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same
| /* NOTE: for powercom_sdcmd_discrete_delay mode it seems we | ||
| * do not read DelayBeforeShutdown at all (not for time), | ||
| * the value is stored and retrieved as DelayBeforeStartup. | ||
| * FIXME: Should anything be changed here? | ||
| */ |
Check notice
Code scanning / CodeQL
FIXME comment Note
| uint16_t val, command; | ||
| int iv; | ||
|
|
||
| /* FIXME: Anything for powercom_sdcmd_discrete_delay? */ |
Check notice
Code scanning / CodeQL
FIXME comment Note
2 participants
Closes: #3000