[Bugfix] Safeguard against submodule parameter deletion in decompress_model #347

kylesayrs · 2025-06-10T20:27:48Z

Purpose

Safeguard against attempts to delete submodule parameters during model decompression
- This occurs when attempting to compress attention modules, which have quantization configs and submodules
- Prior to Deprecate iter_named_leaf_modules and iter_named_quantizable_modules #381, this was skipped by iter_leaf_modules

src/compressed_tensors/compressors/model_compressors/model_compressor.py

Signed-off-by: Kyle Sayers <[email protected]>

dsikka

Why does setting recurse to False fix the issue?

brian-dellabetta previously approved these changes Jun 10, 2025

View reviewed changes

src/compressed_tensors/compressors/model_compressors/model_compressor.py Show resolved Hide resolved

safeguard against removing parameters not immediately on the module

342e3ca

Signed-off-by: Kyle Sayers <[email protected]>

kylesayrs force-pushed the kylesayrs/model_decompress_safeguard branch from 2c7e300 to 342e3ca Compare July 10, 2025 02:05

add safeguard to compress method

d54d00b

Signed-off-by: Kyle Sayers <[email protected]>

kylesayrs dismissed brian-dellabetta’s stale review via d54d00b July 10, 2025 02:07

safeguard against state dict creation

fad52c9

Signed-off-by: Kyle Sayers <[email protected]>

kylesayrs mentioned this pull request Jul 10, 2025

[Bugfix] Only quant-compress modules with weight quantization #387

Merged

brian-dellabetta approved these changes Jul 14, 2025

View reviewed changes

dsikka reviewed Jul 22, 2025

View reviewed changes

dsikka approved these changes Jul 23, 2025

View reviewed changes

dsikka merged commit 17a746c into main Jul 24, 2025
1 check passed

dsikka deleted the kylesayrs/model_decompress_safeguard branch July 24, 2025 02:57