Skip to content

[Quantization] Refactor initialize for activation shape inference #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Quantization] Refactor initialize for activation shape inference #476

wants to merge 5 commits into from
+150 −104

Conversation

kylesayrs
Copy link
Contributor

Purpose

  • Refactor initialize to support passing the shapes of activations
    • While the true shapes of activations are determined at inference/calibration time, the last dimensions can be known from the weight
    • This information is necessary to support group/head quantization, since these strategies need to know the shape of the activation at init time

Changes

  • Use the module weight to infer activation and output quantization shapes
  • Rename _initialize_scale_zero_point to initialize_qparams
  • Introduce strategy_cdiv to share logic related to validating divisibility

@kylesayrs
refactor
8ecaf46 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
reduce diff
92705f2 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
reduce diff
70299f3 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
initialize_qparams
42ee086 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs marked this pull request as draft September 30, 2025 14:51
@kylesayrs
Copy link
Contributor Author

Drafting for now before release

brian-dellabetta
brian-dellabetta reviewed Sep 30, 2025
View reviewed changes
@kylesayrs
Copy link
Contributor Author

I have no clue with tests/test_utils/test_helpers.py is reported to fail, nor why the CI seems to stall. All other tests pass.

@kylesayrs
simplify activation shape
72560d4 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs marked this pull request as ready for review October 1, 2025 15:31
kylesayrs
kylesayrs commented Oct 1, 2025
View reviewed changes
Copy link
Contributor Author

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/neuralmagic/llm-compressor-testing/actions/runs/18167585866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylesayrs @brian-dellabetta