Skip to content

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 16, 2020

This adds possibility to add an interceptor to new OKHttpClient so that we can use pre-defined responses and do not have to use the server.

It is for now just a discussion.
I will open up a corresponding PR on files.

Ref: https://medium.com/ki-labs-engineering/an-easy-way-to-mock-an-api-response-using-retrofit-okhttp-and-interceptor-7968e1f0d050

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings22
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.50%. Comparing base (b39932a) to head (b73e7ec).
⚠️ Report is 2748 commits behind head on master.

Files with missing lines Patch % Lines
...loud/android/lib/common/OwnCloudClientFactory.java 0.00% 5 Missing ⚠️
.../main/java/com/nextcloud/common/NextcloudClient.kt 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   39.50%   39.50%   -0.01%     
==========================================
  Files         136      136              
  Lines        5895     5901       +6     
  Branches      771      773       +2     
==========================================
+ Hits         2329     2331       +2     
- Misses       3218     3222       +4     
  Partials      348      348              
Files with missing lines Coverage Δ
.../main/java/com/nextcloud/common/NextcloudClient.kt 50.00% <62.50%> (-2.46%) ⬇️
...loud/android/lib/common/OwnCloudClientFactory.java 12.50% <0.00%> (-0.71%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants