Do not fetch shares during folder refresh #14989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
commented
Jun 12, 2025
app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java
Outdated
Show resolved
Hide resolved
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
from
c7f5e37 to
04cca36
Compare
ZetaTom
reviewed
Jun 12, 2025
app/src/main/java/com/owncloud/android/ui/fragment/share/RemoteShareRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java
Outdated
Show resolved
Hide resolved
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
from
04cca36 to
df32926
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
from
a7d1bee to
29cc7d0
Compare
|
@tobiasKaminsky Do we still need this? RefreshFolderOperation#L281 |
alperozturk96
added
the
ux-enhancement
alperozturk96
added
the
performance 🚀
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
from
e75cc04 to
39cac1a
Compare
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
2 times, most recently
from
7d332d6 to
8cc61ea
Compare
|
/backport to stable-3.32 |
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
from
8cc61ea to
9d8eb95
Compare
tobiasKaminsky
approved these changes
Jul 22, 2025
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
do-not-fetch-shares-during-folder-refresh
branch
from
39609ff to
d99c1b7
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…ration runs on main thread it must be run on background thread thus executor is used. Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
|
Fixed: When creating a public link share on the server and then refreshing on the client, the icon isn't updated to reflect that. f2.movFixed: When setting up a link share from the app and returning to file list, it also defaults to the create share (avatar plus) icon. f1.mov |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14989.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library PR: nextcloud/android-library#1741
Issue: nextcloud/files-clients#97