Glide v4

[tobiasKaminsky]

• Tests written, or not not needed

Changed areas

• Dashboard widget
• Widget list
• federated avatars
• background image in drawer
• external icons in drawer
• background image in user info
• activity list (adapter)
• notification list (adapter)
• richdocuments template (adapter)
• Unified search items
• backup list

[alperozturk96]

• ksp annotation processor used instead of kapt https://bumptech.github.io/glide/doc/generatedapi.html
• missing components registered to the NextcloudGlideModule
• missing animation added
• wrong glide usages fixed
• java classes converted to the kotlin
• CustomTarget used instead of deprecated SimpleTarget
• missing request listeners added

[alperozturk96]

@tobiasKaminsky I can't verify new glide dependencies. Tried via following commands:

./gradlew --console=plain --dependency-verification lenient -q --write-verification-metadata sha256,pgp help

./gradlew  --write-verification-metadata pgp,sha256 help

./gradlew --write-verification-metadata pgp,sha256 help --export-keys

./gradlew clean --refresh-dependencies

[alperozturk96]

@tobiasKaminsky Looks good to me, what do you think?

[alperozturk96]

External link not working:

createRequestBuilder: Load failed for https://daily.ltd2.nextcloud.com/apps/external/icons/external.svg
2025-06-30 09:43:25.452  9899-9899  GlideHelper             com.nextcloud.client                 E  createRequestBuilder: Error: Failed to load resource
                                                                                                    There was 1 root cause:
                                                                                                    com.bumptech.glide.load.HttpException(Failed to connect or obtain data, status code: 401)
                                                                                                     call GlideException#logRootCauses(String) for more detail
2025-06-30 09:43:25.452  9899-9899  GlideHelper             com.nextcloud.client                 I  Root cause (1 of 1)
                                                                                                    com.bumptech.glide.load.HttpException: Failed to connect or obtain data, status code: 401
                                                                                                    	at com.bumptech.glide.load.data.HttpUrlFetcher.loadDataWithRedirects(HttpUrlFetcher.java:98)
                                                                                                    	at com.bumptech.glide.load.data.HttpUrlFetcher.loadData(HttpUrlFetcher.java:58)
                                                                                                    	at com.bumptech.glide.load.engine.SourceGenerator.startNextLoad(SourceGenerator.java:95)
                                                                                                    	at com.bumptech.glide.load.engine.SourceGenerator.startNext(SourceGenerator.java:88)
                                                                                                    	at com.bumptech.glide.load.engine.DecodeJob.runGenerators(DecodeJob.java:311)
                                                                                                    	at com.bumptech.glide.load.engine.DecodeJob.runWrapped(DecodeJob.java:280)
                                                                                                    	at com.bumptech.glide.load.engine.DecodeJob.run(DecodeJob.java:235)
                                                                                                    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
                                                                                                    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
                                                                                                    	at com.bumptech.glide.load.engine.executor.GlideExecutor$DefaultThreadFactory$1.run(GlideExecutor.java:424)
                                                                                                    	at java.lang.Thread.run(Thread.java:919)
                                                                                                    	at com.bumptech.glide.load.engine.executor.GlideExecutor$DefaultPriorityThreadFactory$1.run(GlideExecutor.java:383)
                                                                                                    Caused by: java.io.FileNotFoundException: https://daily.ltd2.nextcloud.com/apps/external/icons/external.svg
                                                                                                    	at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:255)

You can check on our LTD daily instance.

Fixed here is the external.svg

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15017.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15017-Screenshot-blue-Light-11-43

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	51	48
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	62	62
Dodgy code	300	300
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	48	48
Security	18	18
Total	538	538