Skip to content

BugFix - Fix Toolbar Inconsistency For Favorites Tab #15049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 24, 2025

  • Tests written, or not not needed

The Favorites toolbar is inconsistent when switching between screens.

How to reproduce:

  1. Go to the Favorites tab.
  2. Lock the device screen while on the Favorites tab (or switch to another tab and then return to Favorites)
  3. Unlock the device and reopen the app.
  4. Notice the search bar looks different.

Before

before.mp4

After

after.mp4

tobiasKaminsky

This comment was marked as resolved.

Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/hide-home-search-toolbar-and-sort-list-button-for-favorites branch from 28419b0 to fafb061 Compare June 27, 2025 08:30
@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Jun 27, 2025

Please check if with new behaviour when you click on a folder, that then folder is shown.

Seems like okay.

Screen.Recording.2025-06-27.at.10.33.01.mp4

Copy link

Codacy

Lint

TypemasterPR
Warnings5150
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6262
Dodgy code300300
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total538538

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15049.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 added the ux-enhancement Improvements that refine user interactions, accessibility, or overall usability label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review ux-enhancement Improvements that refine user interactions, accessibility, or overall usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants