🎨 Migrate to outlined icon style

[AndyScherzinger]

• Tests written, or not not needed

[jancborchardt]

Very nice! Some feedback:

• The currently selected entry in the drawer could also get a filled icon, like we do for the bottom rail
• The grid/list view toggle is not outlined yet
• The "Rename" icon in the file menu doesn’t seem to be outlined? Becomes apparent when comparing it to the "Edit" icon – or they don’t use the same icon set/type
• Inside notifications, the bell icon at least is still filled (using daily with the AIO warnings shown). It does flash the outlined variant for a second but then goes to filled.
  • icon retrieved from server, hence "fixed" when the server updated the icon to outlined
• In file details, the tab headings "Activities" and "Sharing" don’t use outlined icons. Again, here the currently active tab could use a filled icon.
• In the scanning flow, the icons are still completely different, and use 2 different icon types?

[AndyScherzinger]

The currently selected entry in the drawer could also get a filled icon, like we do for the bottom rail

@jancborchardt I checked GMail and they don't do this / also not defined in Material 3. We could do it of course. I just need to know if we should do it. For the bottom navigation, yes, GDrive does it as well.

[jancborchardt]

@AndyScherzinger you're right, and K-9 Mail doesnt do filled for the drawer either. And I can't seem to find another app where this is properly testable. (Files by Google has a drawer but switches views with that.)

Then let's keep consistent with the others and not fill the selected entry in the drawer, disregard my feedback about that. :)

[AndyScherzinger]

@jancborchardt

Then let's keep consistent with the others and not fill the selected entry in the drawer, disregard my feedback about that. :)

Didn't see the comment early enough and already built it 😁

The grid/list view toggle is not outlined yet

Any suggested icons?

What we use for grid is https://fonts.google.com/icons?icon.query=grid&icon.size=24&icon.color=%23FFFFFF&selected=Material+Symbols+Outlined:calendar_view_month:FILL@1;wght@400;GRAD@0;opsz@24&icon.platform=android&icon.set=Material+Symbols
In outline it just looks like a table

The list icon doesn't change visually in fille/outline https://fonts.google.com/icons?icon.query=list&icon.size=24&icon.color=%23FFFFFF&selected=Material+Symbols+Outlined:lists:FILL@1;wght@400;GRAD@0;opsz@24&icon.platform=android&icon.set=Material+Symbols

[AndyScherzinger]

list	bullet list	grid

[jancborchardt]

Am fine with either, but "bullet list" works a bit better with the style.

Unrelated but wow, we need to do something about "Recommended files" taking up so much space @tobiasKaminsky

[AndyScherzinger]

Am fine with either, but "bullet list" works a bit better with the style.

bullet list it is then 👍

[AndyScherzinger]

@jancborchardt implemented all your comments on the icons 👍

[AndyScherzinger]

Unrelated but wow, we need to do something about "Recommended files" taking up so much space @tobiasKaminsky

WIP at #15075

[AndyScherzinger]

The unused resources lint warning are due to the icon overrides for the document scanner lib.

[jancborchardt]

Looks great now, very nice @AndyScherzinger! :)

One thing I noticed additionally but it could be done in a follow-up: While of course the folders and filetype icons should be filled (as they are), the icons on groupfolders and shared folders could use the outline variant.

[AndyScherzinger]

One thing I noticed additionally but it could be done in a follow-up: While of course the folders and filetype icons should be filled (as they are), the icons on groupfolders and shared folders could use the outline variant.

@jancborchardt outline variant on the folder-icon itself or the layover "folder-type" icon?

[jancborchardt]

@jancborchardt outline variant on the folder-icon itself or the layover "folder-type" icon?

@AndyScherzinger of the overlaid "group" or "shared" icon. :) As we discussed, the folder itself should always be filled.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	51	51
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	62	62
Dodgy code	300	300
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	48	48
Security	18	18
Total	538	538

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15067.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.