BugFix - Hide Keyboard After Search #15091
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
alperozturk96
added
3. to review
ux-enhancement
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15091.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
kra-mo
approved these changes
Jul 4, 2025
|
LGTM, although one thing I notice is that search results (or at least suggestions) update live in these other apps without having to explicitly initiate a search. I think this would be valuable to do for us too. For example, if after a maybe 500-1000ms timeout, no new input happened, initiate a search automatically. The iOS client also does this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After performing a search and tapping the "DONE" button, the keyboard does not close and the cursor remains visible.
Before
before.mp4
After
after_search.mp4
Similar Behavior From Files, Phone, Maps Apps
gf.mp4
gm.mp4
gp.mp4