BugFix - E2EE Local File Deletion

[alperozturk96]

• Tests written, or not not needed

How to reproduce?

1. Tap the “+” button and create a new folder.
2. Encrypt the folder.
3. Upload a file named “A” from one location on the device.
4. Upload another file with the same name “A” from a different location on the device.
5. From the notification tray, tap the conflict notification and choose “Keep local” in the file conflict popup.
6. Local file gets deleted

Issue?

UploadFileOperation.cleanupE2EUpload line 910 local file exists, line 920 local file not exists. How come unlock folder operation can delete the local file? You can use Debug → Evaluation expression field to check file existence. @tobiasKaminsky

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	48	48
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	59	59
Correctness	62	62
Dodgy code	283	284
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	48	48
Security	18	18
Total	515	516

SpotBugs increased!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15311.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.